[linker] Update linker to recognize debug async notification methods. Fixes #55037 - #2004
Merged
Conversation
Contributor
Author
|
@spouliot can you fast-track this as it needs to go to 15.2 too (Fixes #55037) |
Contributor
|
Build failure |
Contributor
|
@marek-safar got a link to a bug report ? test case ? QA will want this to verify before back porting |
Contributor
Author
|
@spouliot bug number is in description comment |
spouliot
changed the title
Contributor
|
Build success |
Contributor
Author
|
@spouliot can you cherry-pick it or do I need to PR to 15.2 branch ? |
Member
|
@marek-safar please create a PR for 15.2. |
spouliot
added a commit
to spouliot/xamarin-macios
that referenced
this pull request
Sep 26, 2017
Replace dotnet#2704 It's almost identical but it adds unit tests so this does not regress. The issue was already reported in [1] but the fix [2] was incorrect and that was also missed when the bug was verified by QA [3]. [1] https://bugzilla.xamarin.com/show_bug.cgi?id=55037 [2] dotnet#2004 [3] https://bugzilla.xamarin.com/show_bug.cgi?id=55037#c10
spouliot
added a commit
that referenced
this pull request
Sep 27, 2017
…015 (#2782) Replace #2704 It's almost identical but it adds unit tests so this does not regress. The issue was already reported in [1] but the fix [2] was incorrect and that was also missed when the bug was verified by QA [3]. [1] https://bugzilla.xamarin.com/show_bug.cgi?id=55037 [2] #2004 [3] https://bugzilla.xamarin.com/show_bug.cgi?id=55037#c10
spouliot
added a commit
to spouliot/xamarin-macios
that referenced
this pull request
Sep 27, 2017
…015 (dotnet#2782) Replace dotnet#2704 It's almost identical but it adds unit tests so this does not regress. The issue was already reported in [1] but the fix [2] was incorrect and that was also missed when the bug was verified by QA [3]. [1] https://bugzilla.xamarin.com/show_bug.cgi?id=55037 [2] dotnet#2004 [3] https://bugzilla.xamarin.com/show_bug.cgi?id=55037#c10
spouliot
added a commit
that referenced
this pull request
Sep 27, 2017
…015 (#2782) (#2788) Replace #2704 It's almost identical but it adds unit tests so this does not regress. The issue was already reported in [1] but the fix [2] was incorrect and that was also missed when the bug was verified by QA [3]. [1] https://bugzilla.xamarin.com/show_bug.cgi?id=55037 [2] #2004 [3] https://bugzilla.xamarin.com/show_bug.cgi?id=55037#c10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.